Repository navigation
Prevent resource_path request data from overriding nesting - #20
Merged
Merged
Conversation
Trust route-defined resource_path aliases, preserve scoped lookup, and add regression coverage plus the v5.0.2 changelog entry. Co-authored-by: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A request such as
/home/rooms/123.json?resource_path=/roomscould replace the nested path through merged query/body parameters, causing a global lookup instead of the current user's scoped association.Read
resource_pathonly fromrequest.path_parameters, preserving route-defined aliases, memoization, and therequest.pathfallback. Add query/body regressions for scoped reads and deletes, alias and memoization coverage, update the legacy override specs, and document the fix in the v5.0.2 changelog.Validation:
bundle exec rspec— 676 examples, 0 failures. Ruby syntax checks andgit diff --checkpassed. The regressions reproduced the bypass before the fix; cross-user reads and deletes now return 404 while legitimate scoped operations succeed.