Repository navigation
Tag only latest and drop the image cleanup - #25
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused workflow changes match the stated deployment and retention strategy without introducing unresolved issues.
Review effort: Balanced
Findings: None
What changed in this PR
Removes unsafe container cleanup and publishes only rolling latest tags.
Changes:
- Drops the commit-SHA image tag.
- Removes the image cleanup job.
| File | Description |
|---|---|
.github/workflows/ci.yml |
Simplifies image tagging and removes registry cleanup. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The image cleanup is broken:
actions/delete-package-versionscounts package versions, and a multi-arch image is three of them, so keeping 10 versions splits images and leaves tags pointing at deleted manifests. Container registry storage is free, so the replacement is no cleanup at all.latestonly, dropping the<sha>tag.There is no older image to roll back to. A bad deployment or a regression is fixed by reverting the commit on
mainthrough a PR, which rebuilds and deploys.