Repository navigation
Create the directories of generated files - #832
Merged
Merged
Conversation
write_generated_file opened the output path with File::create, which fails with "No such file or directory" when the path's directory does not exist: for a generated file with a nested path, such as com/example/Point.java, or for any file when --output-dir names a directory that does not exist yet. Create the parent directory first.
InsertCreativityHere
approved these changes
Oct 16, 2026
InsertCreativityHere
left a comment
InsertCreativityHere
left a comment
Member
There was a problem hiding this comment.
Looks good to me!
Just one suggestion on the comment, of course :)
Co-authored-by: Austin Henriksen <austin.r.henriksen79@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
write_generated_fileopened the output path withFile::create, which fails when the path's directory does notexist.
slicecreportedE001: unable to write generated file ... No such file or directoryfor a generated file witha nested path, such as
com/example/Point.java, and for any generated file when--output-dirnames a directory thatdoes not exist yet. This change creates the parent directory with
create_dir_allbefore creating the file.Fixes #831
What's Changed
slicec:
sliceccreates the--output-dirdirectory and the subdirectories of the paths that code generators return.