Repository navigation
Owe an action for occurrences under no declaration - #41
Merged
Merged
Conversation
The watch reported "next action: none owed by a person" and exited 0 while the record was refused for undeclared occurrences of the newest release. Evaluation.complete() is false when strangers exist, so the "every step is resolved, but the record was refused" branch never ran, and next_action() considered only steps. next_action() now returns an action naming the count and the projects once nothing earlier is owed. The issue body, the watch line and the exit code (3, waiting) follow from it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
During the 26.2.0 adoption the watch reported
next action: none owed by a personand exited 0 while the record was refused for 13 occurrences under no declaration (resolved in #39). This change makes such occurrences an owed action.Cause
record.refusals()refuses the record whenevaluation.strangersis not empty.Evaluation.complete()is false in the same case, so the watch branch that reports "every step is resolved, but the record was refused" never runs.next_action()considered only steps, project states and publications, so it returnedNone.Change
next_action()takes the strangers. Once nothing earlier is owed, it returns: "account for N occurrence(s) under no declaration in : declare each in governance/energyplus.toml, or change it."evaluate()and the re-evaluation after dispatch inwatch.dispatch().Tests
tests/energyplus/test_watch.pycovers a fully adopted organisation with one stranger: no record is written, the exit code is waiting, and the action appears in the watch output and in the issue body. The test fails onmainand passes with this change.python -m pytest tests -q: 322 passed. The one exception istest_every_caller_in_the_workspace_pins_one_governance_tag, which scans sibling directories and failed only because the worktree sat beside an unrelated checkout.