Repository navigation
Remove the TypeScript divergence entries for the update cases - #45
Merged
Merged
Conversation
@idfkit/core now examines every IdfObject.update entry before applying any and validates the extensible list in its accessor (idfkit-js#80 and #81), so the six typescript entries for the update cases are stale against idfkit-js main at c5f976c. Against it, the corpus passes with the five outstanding typescript entries for other issues and none stale. No entry for the update cases remains; the empty update section is removed and the header recounted: 12 entries over 6 issues and 9 cases, 7 against python and 5 against typescript.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the six typescript entries for the update cases from
known-divergence.toml. They recorded that@idfkit/coreapplied update entries up to the first rejected one and did not examine the extensible list's groups. idfkit-jsmainnow examines every entry before applying any and validates the extensible list in its accessor (idfkit/idfkit-js#80 and #81), so all six are stale against it, which fails the run. As with #44, the change is released as the next tag,conformance-2026.19, and idfkit-js raises its pin to that tag.With the ten python entries already removed (#44), no entry for the update cases remains and none tracks idfkit/idfkit#235.
Changes
known-divergence.toml: six entries removed, and the now-empty update section with them. The header is recounted from the file: 12 entries over 6 issues and 9 cases, 7 against python and 5 against typescript, on a corpus of 74 cases and 226 assertions.Verification
node runners/run.mjs --libraryagainst idfkit-jsmainatc5f976c: 74 cases, 226 assertions; 217 passed, 5 failed, 4 skipped; the 5 failures are the outstanding typescript entries for other issues; none stale; PASS.python -m pytest tests runners/tests -q: 551 passed.tools/validate_governance.py: passes.Effect on consumers
An
@idfkit/corerelease earlier than the one carrying idfkit-js#80 and #81 fails the three refused update cases at this level. idfkit-jsmainpinsconformance-2026.15and is unaffected until its pin is raised.