Repository navigation
Close five not-yet lags whose adoptions have landed - #46
Open
samuelduchesne wants to merge 1 commit into
Open
samuelduchesne wants to merge 1 commit into
samuelduchesne wants to merge 1 commit into
Conversation
Every consumer that carried a not-yet lag now declares the newest stable release of the library it resolves (idfkit 1.1.1, idfkit-js 0.4.0), as tools/sweep_consumers.py reports. The five entries were removed with tools/record_adoption.py close-lag: - envelop (javascript): adopted in idfkit/idfkit-app#235 - idfkit-lsp (javascript): adopted in idfkit/idfkit-lsp#28 - idfkit-lsp (python): adopted in idfkit/idfkit-lsp#30 - idfkit-docs (python): adopted in idfkit/idfkit-docs#41 - idfkit-mcp (python): the cited idfkit/idfkit-mcp#75 closed unmerged, and a later bump reached 1.1.1 tests/test_record_adoption.py read its lags from the live register, so closing them broke two tests and emptied a third. The tests now write the not-yet lags they need into their own copy of the register.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change removes every
not-yetlag fromgovernance/consumers.toml. Each consumer that carried one now declares the newest stable release of the library it resolves: idfkit 1.1.1 and idfkit-js 0.4.0.The entries were removed with
tools/record_adoption.py close-lag, which is the edit the adoption workflow makes.Why one pull request
@idfkit/geometrydeclaration next to the lag.validate:test_closing_one_language_leaves_the_otherread its lags from the live register and expected the idfkit-lsp python lag to remain.Test change
tests/test_record_adoption.pynow writes thenot-yetlags it needs into its own copy of the register (LAGGED), so the tests no longer depend on which lags the live register holds. Without that change, closing these lags broke two tests and lefttest_declining_replaces_a_not_yet_lagwith nonot-yetlag to replace.Verification
python tools/check_consumers.py: passedpython tools/check_consumer_self.pyfor idfkit-app (envelop), idfkit-lsp, idfkit-docs and idfkit-mcp: all passedpython tools/sweep_consumers.py --workspace ..: every direct consumer iscurrentwithlag=None; 0 unexplainedpython -m pytest tests -q: 322 passedAs a governance change, this needs review from a maintainer of the other language. Once it merges, #14, #15, #19 and #38 can be closed, along with idfkit/idfkit-app#226.