Repository navigation
Remove the Python divergence entries closed by idfkit#187 - #48
Merged
Merged
Conversation
idfkit no longer drops an unterminated final object in silence (idfkit#187, idfkit#243): it is a ParseError finding at the object's start line, raised in strict mode and returned by load_idf_with_diagnostics otherwise. The python entries for malformed-truncated-object (parse-outcome, diagnostics) and preserve-unterminated-final (parse-outcome) are therefore stale and are removed, together with the two malformed sections they leave empty. The commentary above the preserve-unterminated-final entry now records 187 as fixed, as it already did for 185. The register now holds 7 entries over 4 issues and 5 cases, 2 against python and 5 against typescript. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LQbHyrMxrueKhwRk34MetU
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
idfkit no longer drops an unterminated final object without a trace (idfkit/idfkit#187, fixed in idfkit/idfkit#243). That object is now a
ParseErrorfinding at its start line. Strict mode raises it, andload_idf_with_diagnosticsreturns it otherwise. Thecorpus (python)check on idfkit#243 fails atconformance-2026.20only because three entries in this register are now stale. This PR removes them.Changes (
known-divergence.tomlonly)malformed-truncated-object/ python /parse-outcomemalformed-truncated-object/ python /diagnosticspreserve-unterminated-final/ python /parse-outcomemalformedsection headers those entries leave empty, as Remove the Python divergence entries closed by idfkit#183 #47 did for the positional section.preserve-unterminated-finalentry to say 187 is fixed, in the style the file already uses for 185.No case inputs, expectations or case prose are changed. The "MAINTAINER WARNING" in
cases/malformed-truncated-object/case.toml, about exponential backtracking, is untouched too. A separate change can update it now that #243 has fixed the pattern.Verification
uv run --project ../idfkit python runners/run.py --library ../idfkitagainst idfkitfix/unterminated-final-object(7c55334, idfkit 1.1.1):There are no stale exceptions and no unexpected failures. The two outstanding exceptions are the expected idfkit#186 encoding entries.
This repo's own checks, as
governance.ymlruns them, pass locally:validate_governance,check_consumersandcheck_rosterpass.pytest tests runners/tests: 551 passed.node --teston the four runner test files: 230 passed.After merge
Tag
conformance-2026.21on the merge commit. idfkit#243 will then pin that tag. This PR does not create or push a tag.Generated by Claude Code