Repository navigation
Show a design-day run without a weather file - #34
Merged
Merged
Conversation
idfkit 1.1.0 accepts a design-day-only run without a weather file. The Design-Day Only example now omits it, and the section states which models still require one.
Contributor
|
Docs preview for this PR is available at: Changed pages: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Summary
idfkit 1.1.0, adopted in #33, accepts a design-day-only run without a weather file (idfkit/idfkit#230). This pull request updates the "Design-Day Only" section of
docs/simulation/running.mdaccordingly.docs/snippets/simulation/running/design_day_only.pynow callssimulate(model, design_day=True)and no longer declares a placeholderweathervariable.GroundHeatTransfer:SlaborGroundHeatTransfer:Basementobjects whose preprocessorGroundHeatTransfer:Controlenables (refused by idfkit);SizingPeriod:WeatherFileDaysorSizingPeriod:WeatherFileConditionType(EnergyPlus fails);Site:WaterMainsTemperatureusingCorrelationFromWeatherFile(EnergyPlus reports a severe error and uses 10 °C).The page's
parity("local-simulation")statement is unchanged. The snippet type-checks only against idfkit 1.1.0 or later, which is why this change follows #33.Specification:
specs/013-design-day-without-weather/in idfkit-unification, FR-018 (tasks T037 and T038).2. Verification
make check: passes.cairosvgwarnings, caused by the absent Cairo library on the build machine; the page renders with the new section. The strict-build check on this pull request is authoritative.