Repository navigation
Use TextEncoder/TextDecoder for UTF-8 - #55
Merged
Merged
Conversation
Every supported runtime has them. The hand-written decoder accepted overlong sequences and encoded surrogates, which TextDecoder replaces with U+FFFD as the encoding standard specifies, and it's faster on large SVGs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ljnxm1Qjrocq1izGajLx8J
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The library had its own UTF-8 encoder and decoder, meant for runtimes without
TextEncoder/TextDecoder. Every supported runtime (Node 22.13+, Deno, Bun, browsers, workers) has both, so it now uses them.src/util/utf8.tsgoes from 59 to 16 lines.The tsconfig only includes the es2022 lib, so the file declares the two classes itself instead of pulling in
lib.dom. The declaration stays inside that module and isn't part of the published types.Used for PNG text chunks and SVG input.