Repository navigation
Animation.frames, deprecate animations as arrays - #60
Merged
Merged
Conversation
Animation extends Array, so its array methods can't be what they seem: map() can return anything, so it returns a plain array, slice() needs an override to keep the class and loop count, filter() and concat() return plain arrays although they only hold frames. animation.frames is the frames as an array, which changes the animation when it's changed and can be replaced as a whole. Using the animation itself as an array is deprecated: in 4.0, Animation won't extend Array. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MLHc7GW46D6BmwtEM2khgr
matmen
force-pushed
the
animation-frames
branch
from
October 16, 2026 07:06
20e28f5 to
551092f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
animation.frames: the frames as a plain array. Changing it (push(),splice(), …) changes the animation, and it can be replaced as a whole.Using the animation itself as an array is deprecated.
Animation(andGIF) extendArray, so array methods can't behave the way they appear to:map()can return anything, so it returns a plain array.slice()needs an override to keep the class and the loop count.filter()andconcat()return plain arrays, although they only ever hold frames.In 4.0,
Animationwon't extendArrayanymore.