Repository navigation
Add node and jest to types in tsconfig - #462
Merged
Merged
Conversation
TypeScript 6.0 changes the default of `types` to `[]`, so `@types/*` packages are no longer included automatically and globals such as `describe`, `expect`, `jest`, `global` and `require` become unresolved. List them explicitly so the build keeps working after the upgrade. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
VerificationRan on this branch (TypeScript 5.9.3, Node.js 24.22.1, pnpm 10.34.7). All commands exited with 0.
On the head of #459 (TypeScript 6.0.3), |
atm-snag2
marked this pull request as ready for review
October 23, 2026 03:43
atm-snag2
requested review from
a team and
kimkim0814
and removed request for
a team
October 23, 2026 03:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Explicitly list
nodeandjestincompilerOptions.typesof the roottsconfig.json.How
src/client/tsconfig.jsonextends the root config, so this setting also applies to the client type check.@types/*packages whose globals are used without an import. Other@types/*packages (react,express,ws, etc.) are still resolved through imports.Why
TypeScript 6.0 changes the default of
typesto[], so@types/*packages are no longer included automatically. On the TypeScript 6.0.3 bump (#459), globals such asdescribe,expect,jest,globalandrequirebecome unresolved and the type check and build fail. Merging this first lets #459 pass as is.Refs