Skip to content

Remove unused pegjs devDependency #12

Closed

Description

@atm-snag2

Why

The top-level pegjs devDependency in package.json is not used by anything in this repository.

  • The build (gulp build) compiles src/tag-data.peg through gulp-peg@0.1.2, which declares its own dependency pegjs ^0.8.0. After npm install, npm ls pegjs shows that gulp-peg resolves its own nested pegjs@0.8.0; the top-level pegjs is never loaded by the build.
  • No source, test, or config file requires pegjs, and no npm script calls the pegjs CLI. The tests load the committed dist/parser.js (generated by PEG.js 0.8.0).
  • pegjs was added together with gulp-peg in 43407df and has never been imported since.

Keeping it means Dependabot keeps opening bump PRs (e.g. #8, pegjs 0.8.0 → 0.10.0) that have no effect on the build or the published dist/ files.

What

Implementation target: increments/tag-data-parser.

Remove the pegjs entry from devDependencies in package.json.

Non-goals:

  • Upgrading the PEG.js version used to generate dist/parser.js (that is controlled by gulp-peg's own dependency).
  • Replacing gulp / gulp-peg.

TODO

Ref

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions