Repository navigation
Remove unused exports-loader - #18
Merged
Merged
Conversation
The webpack entry is src/index.js, which assigns the parser to window.TagDataParser directly and exports nothing. exports-loader is used without options, so it only adds an "EXPORTS FROM exports-loader" comment to dist/bundle.js. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Verification results (on c4e587d, Node.js 24)
|
atm-adachi
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removed
exports-loaderfromdevDependenciesand dropped the loader rule fromwebpack.config.coffee.How
.jsfiles throughexports-loader.dist/bundle.jswas the/*** EXPORTS FROM exports-loader ***/comment (lines 50 and 688).dist/bundle.jswas not regenerated.gulp builddoes not run on current Node.js with gulp 3 (see Make gulp build work with gulp 5 #14, which is stacked on Bump gulp from 3.9.1 to 5.0.1 #9 and not yet on master). The build can be checked once Bump gulp from 3.9.1 to 5.0.1 #9 is merged.package.jsonandwebpack.config.coffeeare the only files changed.Why
#16 (exports-loader 0.6.4 → 5.0.0) fails at
npm iwithERESOLVE, because exports-loader 5 has a peer dependency on webpack ^5 while this repository uses webpack 1.It cannot be fixed within #16 while the build runs on webpack 1: exports-loader 5 calls
this.getOptions(schema), which only exists in the webpack 5 loader API, and requires theexportsoption.Merging #17 (webpack 1.15.0 → 5.112.0) first does not help.
It lets #16 pass
npm i, but the build runs the webpack thatgulp-webpackdepends on (>=1.9.0 <2.0.0-0), wherethis.getOptionsdoes not exist.CI on #17 is green only because CI does not run the build.
The loader has been a no-op since it was added in 009f80d: exports-loader 0.6 only emits exports for names passed as options, and none were passed.
The
dist/bundle.jsbuilt in that commit already contained only the comment.Removing it is a smaller change than upgrading it, whether or not the build moves to webpack 5.
Once this is merged, Dependabot will close #16 because the dependency no longer exists.
Verification
npm iandnpm test.dist/parser.js, so they do not cover the webpack build.webpack.config.coffeewithcoffee-script/registerand check that only theoutputsetting remains.gulp buildand diffingdist/bundle.js, for the reason above. Apart from the unrelated function wrapping noted in Make gulp build work with gulp 5 #14, the expected diff is the removal of the two comment lines and their surrounding blank lines.Results: #18 (comment)
Refs
🤖 Generated with Claude Code