Repository navigation
feature(cqpp): Preprocess Performance optimizations - #4059
Open
awildturtok wants to merge 9 commits into
Open
awildturtok wants to merge 9 commits into
awildturtok wants to merge 9 commits into
Conversation
awildturtok
commented
Sep 30, 2026
| registerValue(value); | ||
| } | ||
|
|
||
| void addNull() { |
|
|
||
| protected abstract int size(); | ||
|
|
||
| public final int getSize() { |
Collaborator
Author
There was a problem hiding this comment.
inline this usage
| } | ||
|
|
||
| public long getLong(int index) { | ||
| if (representations[index] == LONG) { |
Collaborator
Author
There was a problem hiding this comment.
The inverse should be an error case?
| for (BucketData bucket : buckets) { | ||
| final ColumnStore store = column.createStore(bucket.sourceEvents.length); | ||
|
|
||
| if (columnValues != null) { |
Collaborator
Author
There was a problem hiding this comment.
Das kann nicht passieren => ausrollen
awildturtok
commented
Oct 5, 2026
| private int[] sourceEvents; | ||
| private final Map<String, ColumnStore> stores; | ||
|
|
||
| private BucketData(int bucketId, Object2IntMap<String> entityStarts, Object2IntMap<String> entityEnds, int[] sourceEvents, Map<String, ColumnStore> stores) { |
Collaborator
Author
There was a problem hiding this comment.
=> RequiredArgsCtor
awildturtok
force-pushed
the
feature/preprocess-performance
branch
from
October 21, 2026 10:38
d94eec2 to
56cb088
Compare
awildturtok
force-pushed
the
feature/preprocess-performance
branch
from
October 22, 2026 09:28
56cb088 to
2c4dc43
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.