Repository navigation
refactor: currency from the parser config, frontend currency block removed - #4111
Merged
Merged
Conversation
Kadrian
added this pull request to stack #4109
October 21, 2026 11:03
Kadrian
force-pushed
the
refactor/currency-from-parser-config
branch
2 times, most recently
from
October 21, 2026 11:18
51ed567 to
1350c84
Compare
…the frontend currency block is gone
Kadrian
force-pushed
the
refactor/currency-from-parser-config
branch
from
October 21, 2026 11:20
1350c84 to
ead9670
Compare
Kadrian
marked this pull request as ready for review
October 21, 2026 11:21
Collaborator
Author
|
Hey @awildturtok this would be my proposal for how to simplify currency across backend & frontend, curious what you think! |
awildturtok
requested changes
Oct 21, 2026
awildturtok
left a comment
Collaborator
There was a problem hiding this comment.
Somit verhinderst du das crashen der neuen Instanzen und wir können vermeiden alle deployments direkt zu migrieren
awildturtok
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One source of truth for the currency: the frontend gets the ISO code of the parser currency,
frontend.currencyis gone.Stacked on #4108. The old block (
unit, separators,decimalScale) was shaped after a frontend library's props; both sides kept derived values ofpreprocessor.parsers.currencyby hand, and the store read money with the frontend scale while the parser wrote it with the currency's fraction digits./config/frontendsendscurrency: "EUR"; the frontend formats money withIntlin the app locale (history, preview, money range field) and derives symbol and decimals from the codeMoneyIntStore, the arrow printer (no hard-coded 2)frontend.currencyis ignored when a deployment config still sets it (@JsonIgnoreProperties, review request), so configs can drop the block at their own pacepackage.jsonunchanged; its backend reads the old block in two places and gets the same one-line change with the submodule bumpopenapi.yamlthe linter now reports (unquotedNULLenum value,uniqueItemson items instead of the arrays); the file had not changed since 2024, so the lint job never ran on it