Repository navigation
Keep the session through updates; login page says e-ink displays - #6
Merged
Merged
Conversation
Signing in again after every Sparkle update came from TokenStore.save: it deleted the Keychain item and added a new one on every save. On this Mac the item had been created by the first Developer ID install (~/Applications/inklet.app, 2026-09-16) and never changed since, although the backend rotates the refresh token every 72 hours: the delete was refused, the add failed with errSecDuplicateItem, and the fresh tokens lived only in memory. The next launch — an update relaunch — presented the old refresh token, the backend answered 401, and the app signed out. Saves now update the existing item in place and only fall back to delete-and-add; if the Keychain still refuses, the session is kept in the 0600 file until the Keychain accepts it, instead of being dropped. The login page reads "Your second brain, on e-ink displays."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signing in again after every Sparkle update came from TokenStore.save:
it deleted the Keychain item and added a new one on every save. On this
Mac the item had been created by the first Developer ID install
(~/Applications/inklet.app, 2026-09-16) and never changed since, although
the backend rotates the refresh token every 72 hours: the delete was
refused, the add failed with errSecDuplicateItem, and the fresh tokens
lived only in memory. The next launch — an update relaunch — presented the
old refresh token, the backend answered 401, and the app signed out.
Saves now update the existing item in place and only fall back to
delete-and-add; if the Keychain still refuses, the session is kept in the
0600 file until the Keychain accepts it, instead of being dropped. The
login page reads "Your second brain, on e-ink displays."
Build and the 75 tests pass with the Xcode toolchain.