Repository navigation
fix(composer): a link alone sends; options and send button side by side - #7
Merged
Merged
Conversation
- A link on its own now sends to a Virtual Display. That path passed on
only the text and the one picture, so a link-only draft reached the
generator as nothing at all ("Invalid presentation content or output
size.") and a link next to text was dropped without a word. Every send
now builds its Content from the whole draft (`AppModel.draftAssets`).
- Just upload goes through whichever display is still picked. With a
Virtual Display selected it used to fail with "Virtual Displays publish
their own frame."
- Add Link takes only what the backend takes: http or https with a real
host, no credentials. A bare example.com reads as https. A pasted
non-web URL (mailto:, an app scheme) goes in as text instead of being
refused after upload.
- The send option is a menu of its own beside the display menu, with a
separate Send button (Save for Just upload). ⌘↩ and ⌥1…⌥4 work as
before.
- The option picked last comes back next time. A display page still
starts on Push to device instead of Just upload, and a remembered Show
as-is waits for a draft it can take: one picture.
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
What
Fixes
AppModel.draftAssets.example.comreads as https. Pasted non-web URLs (mailto:, app schemes) go in as text rather than failing after upload withinvalid_asset.Composer layout
[Send option ▾] [Display ▾] [Send]. The option menu is aPickerlike the display menu, and the send button stands alone. It reads "Save" for Just upload.Remembered option
Verification
swift buildis clean, andswift testpasses 79 tests. NewComposerDraftTestscover link-only drafts, ordering, and link normalisation/refusals../Scripts/build-app.sh debugbuilds and signs.