Repository navigation
test: increase test coverage - #533
Open
arjun-rajappa wants to merge 4 commits into
Open
arjun-rajappa wants to merge 4 commits into
arjun-rajappa wants to merge 4 commits into
Conversation
arjun-rajappa
force-pushed
the
increase-test-coverage
branch
2 times, most recently
from
September 29, 2026 05:29
fe8d686 to
19c412b
Compare
arjun-rajappa
marked this pull request as ready for review
September 30, 2026 14:27
arjun-rajappa
marked this pull request as draft
September 30, 2026 14:29
arjun-rajappa
marked this pull request as ready for review
October 7, 2026 05:35
CagriYonca
requested changes
Oct 21, 2026
CagriYonca
left a comment
CagriYonca
left a comment
Contributor
There was a problem hiding this comment.
A few refactoring issues, using a single client for each DB test in the setup function and a potential false-positive issue. If the advice is right, could you apply it to all potential parts of the PR?
Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
Refactor negative-assertion tests to use inline block predicates (spans.any? / spans.find) instead of find_first_span_by_name. Also fixes mongo mock expectations, corrects rack W3C tracestate IDs to valid hex, and updates the expected no-in= context shape. Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
Create a single client in setup and reuse it across tests in aws_test and mongo_test. Replace silent 'return unless' / 'next unless' / 'if span' guards with refute_nil assertions in the aws, dalli, mongo and net_http tests so they can no longer pass without a span being generated. Fix the two tests this exposed: finish the span and enable allow_exit_as_root in the mongo filter_statement test, and open a real plain-HTTP connection in the net_http https URL test so the instrumentation is not bypassed by WebMock. Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
arjun-rajappa
force-pushed
the
increase-test-coverage
branch
from
October 21, 2026 11:53
074b639 to
5b221d8
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.