Repository navigation
fix: moov-io/bertlv update to fix tlv panic error - #3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates dependencies and adds new tests to improve the robustness of the
tlv.ValidateAmountfunction. The main focus is to ensure that malformed or random TLV payloads do not cause panics, addressing issues with previous versions of thebertlvlibrary.Dependency updates:
github.com/moov-io/bertlvfromv0.1.0to a newer pre-release version to fix panics on malformed input.github.com/stretchr/testifytov1.12.1and addedgo.yaml.in/yaml/v3as an indirect dependency.Testing improvements:
TestValidateAmountDoesNotPanicOnMalformedLength,TestValidateAmountDoesNotPanicOnRandomPayloads, andFuzzValidateAmount) to verify that malformed or random TLV payloads do not cause panics and always return a parsing error.math/rand/v2package to support randomized testing.