Skip to content

feat: replace outgoing_payment.completed with payment.completed - #2276

Merged
dragosp1011 merged 1 commit into
v1from
dragos/int-656-payment-completed-webhook
Nov 1, 2026
Merged

dragosp1011 merged 1 commit into
v1from
dragos/int-656-payment-completed-webhook

Conversation

@dragosp1011

Copy link
Copy Markdown
Contributor

Context

  • fixes #

Changes

  • Handle the Rhyza payment.completed webhook: move debitAmount from the sender's GateHub wallet to the settlement wallet, mark the transaction as completed and notify the sender (MONEY_SENT, or MONEY_SENT_SHOP for instant payments)
  • Drop the liquidity withdrawal from the Rafiki flow, since Rhyza has no liquidity to withdraw
  • Add payment.completed to webhook validation, types and mocks
  • Add tests for settlement, the shop message type, zero amounts, GateHub transfer failure, a missing GateHub account and webhook validation

@github-actions github-actions Bot added package: wallet/backend Wallet backend implementations type: test Improvements or additions to tests type: source Source changes labels Oct 30, 2026
@dragosp1011
dragosp1011 marked this pull request as ready for review October 30, 2026 14:36
@dragosp1011
dragosp1011 merged commit 030493c into v1 Nov 1, 2026
16 of 17 checks passed
@dragosp1011
dragosp1011 deleted the dragos/int-656-payment-completed-webhook branch November 1, 2026 13:22
@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown

🎉 This PR is included in version 1.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: wallet/backend Wallet backend implementations released on @v1 type: source Source changes type: test Improvements or additions to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants