Repository navigation
Conversation
Use correspondence fitness instead of transformation trace in reconstruction and RANSAC examples. Preserve the overlap gate and FGR output behavior, and cover valid and failed transforms with regression tests.
|
Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Motivation and Context
A rigid transformation's trace depends on rotation, not translation. The existing
trace() == 4.0check rejects successful pure-translation registrations. Replacing it with an exact identity comparison would still reject valid identity alignments.Description / plan summary
The goal is to distinguish missing correspondences from a valid zero-rotation alignment without changing registration algorithms, public APIs, or benchmark output formats.
Validation
Tested the current-main Python examples (base
b6c5e196384ad71e75b6e6f9c5da22d046221f1d) on Linux, CPython 3.12.15, NumPy 2.5.4, and the officialopen3d-cpu==0.20.0wheel. This was not a fresh C++ source build.python -m pytest python/test/pipelines -q: 36 passed.6e-16. Four valid results had trace exactly four and were rejected by the old check. This does not benchmark FPFH matching quality.git diff --checkpassed.No GPU run, full C++ build, full test suite, real-data reconstruction, or complete documentation build was performed.
Checklist
AI assistance was used for implementation and validation; the commands and results reported above were executed locally.