Repository navigation
Fix/region selector snapshot race - #163
Merged
castdrian merged 2 commits intoOct 25, 2026
Merged
Conversation
…ezing the screen The previous fix took a fresh window list once the selector was showing, but the panels only reach ScreenCaptureKit's list a few milliseconds after they appear. The first snapshot never contained them, so ishare wasn't excluded and the freeze-frames still caught the overlay with its dimming and the crosshair guides at the pointer's starting position. The backdrop capture now polls the shareable content until it lists every selector panel, giving up after 500 ms.
…er appears Now that the selector opens before the freeze-frames are ready, the view had no backdrop for its first frames and fell back to the coordinate pill meant for when the magnifier is off, which then vanished as the magnifier took over. The screenshot flow now tells the selector that backdrops are coming, and each display holds the pill back until its backdrop arrives. Displays that never get one, and selectors that are never sent backdrops such as the interval capture, still show the coordinates.
Contributor
Code coverage
Every coverage minimum is met. Measured on ce9bfd4. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This time correctly tested a fix for doubled selector, stuck pointer and flicker on x,y position.
Sorry for last one #162 wasn't tested, since I had issues with local build.