Repository navigation
Feat/region selector toggles - #164
Merged
Merged
Conversation
…ezing the screen The previous fix took a fresh window list once the selector was showing, but the panels only reach ScreenCaptureKit's list a few milliseconds after they appear. The first snapshot never contained them, so ishare wasn't excluded and the freeze-frames still caught the overlay with its dimming and the crosshair guides at the pointer's starting position. The backdrop capture now polls the shareable content until it lists every selector panel, giving up after 500 ms.
…er appears Now that the selector opens before the freeze-frames are ready, the view had no backdrop for its first frames and fell back to the coordinate pill meant for when the magnifier is off, which then vanished as the magnifier took over. The screenshot flow now tells the selector that backdrops are coming, and each display holds the pill back until its backdrop arrives. Displays that never get one, and selectors that are never sent backdrops such as the interval capture, still show the coordinates.
The region selector opened the window picker with region mode turned off, so Space only went one way. The two selectors now switch to each other with Space as often as needed, and the allowsRegionMode flag that no caller set any more is gone.
…selector Z flips the same preference as the "Show magnifier while selecting" setting, the way G does for the guides. Selectors with a frozen frame show the magnifier, which includes the position, and the others (recording, scrolling and interval capture) show the coordinate pill instead, so nothing follows the pointer while the preference is off. The hint bar lists Z for each case, and RegionSelector.Options drops showsMagnifier since having backdrops now decides which readout appears.
…electors The recording selector now offers L for the last region and remembers the area it records, sharing the store with screenshots. The screenshot selector shows a "Select the area to capture" hint like the recording and scrolling ones already do.
Contributor
Code coverage
Every coverage minimum is met. Measured on a51dc29. |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
🎉 This PR is included in version 5.5.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few changes to overlay (both screenshot and movie)
Tested, works smooth.