Build against the jdolan/SDL ObjectivelyGPU tag - #66
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The release workflow still compiles source dependencies against stock Homebrew SDL3 rather than the required fork tag.
Review effort: Balanced
Findings: 1
What changed in this PR
Updates CI and release packaging to align SDL dependencies with ObjectivelyGPU.
Changes:
- Builds SDL3 from the
jdolan/SDLObjectivelyGPUtag on macOS and Linux CI. - Stops republishing the SDL3 xcframework.
- Updates SDL3_image to 3.4.4 and documents the fork requirement.
| File | Description |
|---|---|
.github/workflows/build.yml |
Builds the tagged SDL3 fork in macOS and Linux CI. |
.github/workflows/release.yml |
Removes SDL3 xcframework release packaging. |
Frameworks/fetch-sdl3-extensions.sh |
Updates SDL3_image to 3.4.4. |
Documentation/install.md |
Documents the SDL3 fork and query API. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
jdolan
force-pushed
the
sdl-fork-tag
branch
from
September 30, 2026 17:08
325523c to
9deb401
Compare
ObjectivelyGPU pins SDL3 to the ObjectivelyGPU tag of jdolan/SDL, which carries the SDL_gpu query API. macOS CI used unpinned Homebrew sdl3 and Linux CI used upstream 3.4.12. Both now build SDL3 from the tag. macOS CI also builds SDL3_image 3.4.4 and SDL3_ttf 3.2.2 from source, as Linux CI does, because Homebrew's builds link Homebrew's sdl3 and would load a second SDL3. Releases no longer republish SDL3.xcframework.zip, because the fork publishes it. Windows needs no change: sdl3.targets imports the ObjectivelyGPU targets. See jdolan/quetoo#1093. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Windows and Linux use SDL3_image 3.4.4, but the Apple xcframework still fetched 3.4.0. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
jdolan
force-pushed
the
sdl-fork-tag
branch
from
September 30, 2026 17:08
9deb401 to
08e3c7e
Compare
The release job installed Homebrew's stock sdl3, sdl3_image and sdl3_ttf, and built Objectively and ObjectivelyGPU against them for MVC's configure checks. It now builds all three from source, as build.yml does. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds ObjectivelyMVC CI against the
ObjectivelyGPUtag of jdolan/SDL, to match jdolan/ObjectivelyGPU#7. See jdolan/quetoo#1093.sdl3. It now builds SDL3 from the tag, and SDL3_image 3.4.4 and SDL3_ttf 3.2.2 from source, as Linux CI does. Homebrew'ssdl3_imageandsdl3_ttflink Homebrew'ssdl3, so the process loaded two SDL3 libraries and the SVG tests inImage.cfailed.release-3.4.12.SDL3.xcframework.zip.Windows needs no change, because
sdl3.targetsimports the ObjectivelyGPU targets. This PR does not depend on the GPU PR, but the GPU PR SHOULD merge first.🤖 Generated with Claude Code