Build SDL3 in-tree for Xcode - #67
Merged
Merged
Conversation
MVC's header search paths put $(HOMEBREW_PREFIX)/include before the framework search path, so <SDL3/...> resolved to Homebrew's stock headers while MVC linked the fork. The two disagree on the size of SDL_GPUDepthStencilTargetInfo. As in ObjectivelyGPU, the workspace now builds SDL3.framework from SDL's own Xcode project in the sibling ../SDL3 checkout of the jdolan/SDL ObjectivelyGPU tag, and the header search paths name its include directory ahead of Homebrew. The release job already clones that checkout. See jdolan/quetoo#1093. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The workspace, project references, header ordering, and release workflow consistently use the same SDL3 source tree.
Review effort: Balanced
Findings: None
What changed in this PR
Builds SDL3 in-tree for Xcode to prevent header/framework ABI mismatches.
Changes:
- Adds SDL3’s Xcode project to the workspace.
- Links the built framework and prioritizes matching headers.
- Removes the obsolete release fetch step.
| File | Description |
|---|---|
ObjectivelyMVC.xcworkspace/contents.xcworkspacedata |
Adds the sibling SDL3 project. |
ObjectivelyMVC.xcodeproj/project.pbxproj |
Uses the in-tree SDL3 framework and headers. |
Frameworks/fetch-sdl3-extensions.sh |
Documents SDL3’s new source. |
.github/workflows/release.yml |
Reuses the existing SDL3 checkout. |
Files not reviewed (1)
- ObjectivelyMVC.xcworkspace/contents.xcworkspacedata: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
The workspace builds SDL3.framework from ../SDL3 and fails without it. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds SDL3 in-tree for the Xcode workspace, as jdolan/ObjectivelyGPU#8 does. See jdolan/quetoo#1093.
MVC's header search paths put
$(HOMEBREW_PREFIX)/includebefore the framework search path, so<SDL3/...>resolved to Homebrew's stock headers while MVC linked the fork. The two disagree on the size ofSDL_GPUDepthStencilTargetInfo.ObjectivelyMVC.xcworkspaceadds../SDL3/Xcode/SDL/SDL.xcodeproj, and the targets linkSDL3.frameworkfrom the build products.$(SRCROOT)/../SDL3/includeahead of Homebrew.release.ymldrops the fetch step. It already clones the fork intoSDL3, next to the other checkouts.Verification: a local Xcode build of the
ObjectivelyMVCscheme against the GPU branch succeeds. Its objects includeSDL3/include/SDL3/SDL_gpu.h, and MVC,SDL3_imageandSDL3_ttfall link@rpath/SDL3.framework. CI does not build the Xcode projects.🤖 Generated with Claude Code