Repository navigation
Fix cleanup of adjacent numeric separators - #76
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The separator cleanup consumes the digit after each match, so it skips the next separator when only one digit separates them. For example,
parse('1_2_3s')returns3012instead of123000.Use a lookahead for the following digit so every separator between digits is removed. This also fixes adjacent locale group separators and placeholders in fractional values.
Validation: all 106 existing tests pass. A separate 17-case reproduction covering placeholders, grouping, decimals, signs, output units, and German locale values also passes.
Prepared with OpenAI Codex assistance.