Repository navigation
Minor updates: formatting, docstring updates, quality assurance, import fixes - #70
Open
astrobatty wants to merge 8 commits into
Open
astrobatty wants to merge 8 commits into
astrobatty wants to merge 8 commits into
Conversation
Collaborator
Author
|
I reviewed the updated files, but it looks like there are some sha256 checks prevented the tests from passing. @johnh2o2 could you take a look at this? Thanks |
johnh2o2
requested changes
Oct 16, 2026
johnh2o2
left a comment
johnh2o2
left a comment
Owner
There was a problem hiding this comment.
Left some comments / questions, thanks a ton!
| # there (see full_bls_no_sol_fused in bls_common.cuh); any other | ||
| # (noverlap, dphi) combination keeps the host-side loop, as do | ||
| # caller-provided ``functions`` dicts without the fused kernel. | ||
| fused_func = None |
Collaborator
Author
There was a problem hiding this comment.
Nope. It is simply not used. The variable is defined within the try-except clause.
| which BLS/CE users never need to load. | ||
| """ | ||
|
|
||
| from .nfft_memory import NFFTMemory |
Owner
There was a problem hiding this comment.
I think the lines below lazily import these modules so things don't break when you don't have GPU (forget if there's other reasons like overhead etc.) any reason to revert to non-lazy imports?
Collaborator
Author
There was a problem hiding this comment.
You are right. I shouldn't do this.
Owner
|
Yea will do |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.