Allow dial timeout to exceed IO timeout - #38
Merged
Merged
Conversation
DialTimeout could not be raised above IOTimeout: Connect collapsed it into IOTimeout, and dial() capped it at 5 seconds on top of that. A caller that needs a long connection setup but short per-command deadlines had no way to express it. ReconnectPause still defaults to DialTimeout * 2, so raising the dial timeout alone also lengthens the pause between reconnect attempts.
g7r
marked this pull request as ready for review
September 11, 2026 16:33
isopov
approved these changes
Sep 11, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DialTimeout could not be raised above IOTimeout: Connect collapsed it
into IOTimeout, and dial() capped it at 5 seconds on top of that. A
caller that needs a long connection setup but short per-command
deadlines had no way to express it.
ReconnectPause still defaults to DialTimeout * 2, so raising the dial
timeout alone also lengthens the pause between reconnect attempts.