Repository navigation
fix: JOOWP-304: [CORE] make perf THEME=jooservices cannot start Chromium for Lighthouse (G7) - #53
Conversation
…ium for Lighthouse (G7) `perf-vm.sh` now accepts JOOWP ticket worktrees, so `make perf` can route Lighthouse to the Dev VM browser instead of failing before it starts. `perf.mjs` now gives a clear error instead of trying to spawn a missing Playwright Chromium. The real `make perf THEME=jooservices` run and its evidence under `artifacts/reports/` could not be done here because the sandbox has no `ssh` and no Dev VM, so AC1 and AC2 still need that run. Refs: JOOWP-304 AI-Run: 22e562d8-0546-451d-ab71-e3339434a0ad (claude-02, claude/sonnet)
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
AI Flow verify: FAIL (verify failed). Findings:
Checks: |
…e-perf-theme-jooservices-cannot
…ium for Lighthouse (G7) JOOWP tickets are now accepted in the Makefile, `init-env.sh`, `wp-task.sh` and `shared-db.sh`, so `make perf` gets past `boot-cost` on a JOOWP branch and reaches the browser runner. A new regression test covers this route. The unrelated resume zip is restored to match `develop`. Refs: JOOWP-304 AI-Run: 72fb6378-3e4d-45cb-806f-9b962da1c0f4 (claude-01, claude/sonnet)
|
AI Flow verify: FAIL (CI failed). Findings:
Checks: composer install ok; npm ci ok; make lint passed; make analyse passed (PHPStan no errors, deptrac 0 violations); make test-unit passed (48 files, 372 tests); tests/tooling/ticket-prefix.sh passed; tools/perf.test.mjs passed (12 tests); make perf not run (needs the Dev VM, out of scope per owner amendment). |
…ium for Lighthouse (G7) Extended the JOOWP regression test to check that `perf-vm.sh` routes runs to the Dev VM browser, and added a verification report. Static-analysis checks passed locally; the owner amendment’s Lighthouse run and AC1/AC2 runtime evidence were not produced, as recorded in the [report](/srv/aiflow/work/JOOWP/JOOWP-304-core-make-perf-theme-jooservices-cannot/docs/dev-reports/JOOWP-304.md). Refs: JOOWP-304 AI-Run: 36bb5989-9c54-4794-b15f-295c8888a865 (codex-03, codex/gpt-6-luna)
|
AI Flow verify: FAIL (conflicts with develop). Findings:
|
…ium for Lighthouse (G7) Resolved the conflict in [tools/perf.test.mjs](/srv/aiflow/work/JOOWP/JOOWP-304-core-make-perf-theme-jooservices-cannot/tools/perf.test.mjs), preserving both branches’ regression tests. Updated the [JOOWP-304 report](/srv/aiflow/work/JOOWP/JOOWP-304-core-make-perf-theme-jooservices-cannot/docs/dev-reports/JOOWP-304.md) with check results and the Lighthouse evidence not produced under the owner amendment. Refs: JOOWP-304 AI-Run: d17a6f1a-9bec-46f4-b51a-881af4d69775 (codex-02, codex/gpt-6-luna)
|
AI Flow verify: FAIL (CI failed). Findings:
Checks: |
…ium for Lighthouse (G7) Fixed the tooling regression by unsetting the inherited `JOOS_TICKET` when the test checks branch detection, and updated the [verification report](/srv/aiflow/work/JOOWP/JOOWP-304-core-make-perf-theme-jooservices-cannot/docs/dev-reports/JOOWP-304.md). The Dev VM Lighthouse run and its evidence were not produced, as directed by the owner amendment. Refs: JOOWP-304 AI-Run: bf1cfec5-671f-4494-b60a-a27da49b5f34 (codex-01, codex/gpt-6-luna)
|
AI Flow verify: FAIL (verify failed). Findings:
Checks: |
…ium for Lighthouse (G7) Updated [perf-vm.sh](/srv/aiflow/work/JOOWP/JOOWP-304-core-make-perf-theme-jooservices-cannot/docker/scripts/perf-vm.sh) to expose the SSH forward and verify `/json/version` from the Node runtime before Lighthouse starts; OpenSSH documents `-g` for remote clients of local forwards ([ssh(1)](https://man.openbsd.org/OpenBSD-7.7/ssh.1)). The report records that the Lighthouse run and AC1/AC2 evidence were not produced, per the owner amendment. Refs: JOOWP-304 AI-Run: ce5cf1af-de7d-4c48-9a31-a8b11b571f6c (codex-01, codex/gpt-6-luna)
|
AI Flow verify: FAIL (verify failed). Findings:
Checks: composer install, npm ci, make lint, make analyse and make test-unit all passed (exit 0). tests/tooling/ticket-prefix.sh passed. make perf was not run (out of scope under the owner amendment, and the Dev VM is unavailable here). |
…e-perf-theme-jooservices-cannot
…ium for Lighthouse (G7) The DevTools tunnel in `perf-vm.sh` binds only to the Docker bridge gateway address (`PERF_CDP_BIND` overrides it) and `ssh -g` is removed. The Node runtime still verifies the endpoint before Lighthouse starts, and the grep assertions in `tests/tooling/ticket-prefix.sh` now enforce the restricted bind. The Dev VM Lighthouse run and its AC1/AC2 evidence were not produced, per the owner amendment. Refs: JOOWP-304 AI-Run: e722534a-8337-42d7-915d-3f82007f8271 (claude-02, claude/sonnet)
|
AI Flow verify: FAIL (verify failed). Findings:
Checks: |
…ium for Lighthouse (G7) Restored the package archive to match `origin/develop` and corrected the Vitest totals in [JOOWP-304.md](/srv/aiflow/work/JOOWP/JOOWP-304-core-make-perf-theme-jooservices-cannot/docs/dev-reports/JOOWP-304.md). The report records that Lighthouse evidence was not produced, as directed by the owner amendment. Refs: JOOWP-304 AI-Run: f2d195da-5a05-4029-b174-2e13d220a8e1 (codex-02, codex/gpt-6-luna)
Jira: JOOWP-304
Summary
perf-vm.shnow accepts JOOWP ticket worktrees, somake perfcan route Lighthouse to the Dev VM browser instead of failing before it starts.perf.mjsnow gives a clear error instead of trying to spawn a missing Playwright Chromium. The realmake perf THEME=jooservicesrun and its evidence underartifacts/reports/could not be done here because the sandbox has nosshand no Dev VM, so AC1 and AC2 still need that run.Tests
composer installandnpm ciran.make lintpasses after a Prettier fix.make analysereported 0 errors.make test-unitpassed (48 files, 372 tests, including the 2 newlocalChromePathtests).make perf THEME=jooserviceswas not run because the Dev VM is unreachable.Run
Opened as a draft by AI Flow v4; verification runs next (In Verify).