Skip to content

fix: JOOWP-304: [CORE] make perf THEME=jooservices cannot start Chromium for Lighthouse (G7) - #53

Merged
jooservices-aiflow-bot[bot] merged 10 commits into
developfrom
JOOWP-304-core-make-perf-theme-jooservices-cannot
Oct 23, 2026
Merged

jooservices-aiflow-bot[bot] merged 10 commits into
developfrom
JOOWP-304-core-make-perf-theme-jooservices-cannot

Conversation

@jooservices-aiflow-bot

Copy link
Copy Markdown
Contributor

Jira: JOOWP-304

Summary

perf-vm.sh now accepts JOOWP ticket worktrees, so make perf can route Lighthouse to the Dev VM browser instead of failing before it starts. perf.mjs now gives a clear error instead of trying to spawn a missing Playwright Chromium. The real make perf THEME=jooservices run and its evidence under artifacts/reports/ could not be done here because the sandbox has no ssh and no Dev VM, so AC1 and AC2 still need that run.

Tests

composer install and npm ci ran. make lint passes after a Prettier fix. make analyse reported 0 errors. make test-unit passed (48 files, 372 tests, including the 2 new localChromePath tests). make perf THEME=jooservices was not run because the Dev VM is unreachable.

Run

  • account: claude-02 (claude/sonnet)
  • run: 22e562d8-0546-451d-ab71-e3339434a0ad, fence 5
  • files changed: 4

Opened as a draft by AI Flow v4; verification runs next (In Verify).

…ium for Lighthouse (G7)

`perf-vm.sh` now accepts JOOWP ticket worktrees, so `make perf` can route Lighthouse to the Dev VM browser instead of failing before it starts. `perf.mjs` now gives a clear error instead of trying to spawn a missing Playwright Chromium. The real `make perf THEME=jooservices` run and its evidence under `artifacts/reports/` could not be done here because the sandbox has no `ssh` and no Dev VM, so AC1 and AC2 still need that run.

Refs: JOOWP-304
AI-Run: 22e562d8-0546-451d-ab71-e3339434a0ad (claude-02, claude/sonnet)
@coderabbitai

coderabbitai Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 7475a945-2669-4bce-bca3-0490c7f3ffeb

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jooservices-aiflow-bot

Copy link
Copy Markdown
Contributor Author

AI Flow verify: FAIL (verify failed).

Findings:

  • wp-task.sh, Makefile, and init-env.sh: perf-vm.sh accepts JOOWP, but make perf runs boot-cost first. That path still derives and validates only JOOS/JOOWT tickets, so on JOOWP-304 it exits before reaching the new browser runner. Extend ticket handling across these entry points and add a regression test for the JOOWP make perf route.
  • jooservices-resume-0.1.0.zip: This unrelated archive changed even though its extracted files are identical. Its new checksum (417608…) no longer matches the recorded JOOWT-288 checksum (c0da51…). Remove this archive change from the PR.

Checks: composer install --no-interaction --prefer-dist PASS; npm ci --no-audit --no-fund PASS; make lint PASS; make analyse PASS; make test-unit PASS (288 PHPUnit tests, 3,266 assertions; 372 Vitest tests); git diff --check PASS. make perf THEME=jooservices could not reach Lighthouse because the shared Docker configuration is unavailable (ERROR: could not locate the Workspaces root shared Docker configuration.); ssh is also unavailable. The existing perf report is from the JOOWT-288 run, so AC1 and AC2 remain unverified for this change. No AGENTS.md or docs/SPEC.md was present.

…ium for Lighthouse (G7)

JOOWP tickets are now accepted in the Makefile, `init-env.sh`, `wp-task.sh` and `shared-db.sh`, so `make perf` gets past `boot-cost` on a JOOWP branch and reaches the browser runner. A new regression test covers this route. The unrelated resume zip is restored to match `develop`.

Refs: JOOWP-304
AI-Run: 72fb6378-3e4d-45cb-806f-9b962da1c0f4 (claude-01, claude/sonnet)
@jooservices-aiflow-bot

Copy link
Copy Markdown
Contributor Author

AI Flow verify: FAIL (CI failed).

Findings:

Checks: composer install ok; npm ci ok; make lint passed; make analyse passed (PHPStan no errors, deptrac 0 violations); make test-unit passed (48 files, 372 tests); tests/tooling/ticket-prefix.sh passed; tools/perf.test.mjs passed (12 tests); make perf not run (needs the Dev VM, out of scope per owner amendment).

…ium for Lighthouse (G7)

Extended the JOOWP regression test to check that `perf-vm.sh` routes runs to the Dev VM browser, and added a verification report. Static-analysis checks passed locally; the owner amendment’s Lighthouse run and AC1/AC2 runtime evidence were not produced, as recorded in the [report](/srv/aiflow/work/JOOWP/JOOWP-304-core-make-perf-theme-jooservices-cannot/docs/dev-reports/JOOWP-304.md).

Refs: JOOWP-304
AI-Run: 36bb5989-9c54-4794-b15f-295c8888a865 (codex-03, codex/gpt-6-luna)
@jooservices-aiflow-bot

Copy link
Copy Markdown
Contributor Author

AI Flow verify: FAIL (conflicts with develop).

Findings:

  • merge: the branch conflicts with the latest develop in tools/perf.test.mjs. Merge develop into the branch and resolve the conflicts.

…ium for Lighthouse (G7)

Resolved the conflict in [tools/perf.test.mjs](/srv/aiflow/work/JOOWP/JOOWP-304-core-make-perf-theme-jooservices-cannot/tools/perf.test.mjs), preserving both branches’ regression tests. Updated the [JOOWP-304 report](/srv/aiflow/work/JOOWP/JOOWP-304-core-make-perf-theme-jooservices-cannot/docs/dev-reports/JOOWP-304.md) with check results and the Lighthouse evidence not produced under the owner amendment.

Refs: JOOWP-304
AI-Run: d17a6f1a-9bec-46f4-b51a-881af4d69775 (codex-02, codex/gpt-6-luna)
@jooservices-aiflow-bot

Copy link
Copy Markdown
Contributor Author

AI Flow verify: FAIL (CI failed).

Findings:

Checks: composer install passed; npm ci passed; make lint passed; make analyse passed (0 violations, 0 errors); make test-unit passed (288 PHPUnit tests, 373 Vitest tests); bash tests/tooling/ticket-prefix.sh passed; git diff --check passed; Lighthouse run not performed per owner amendment.

…ium for Lighthouse (G7)

Fixed the tooling regression by unsetting the inherited `JOOS_TICKET` when the test checks branch detection, and updated the [verification report](/srv/aiflow/work/JOOWP/JOOWP-304-core-make-perf-theme-jooservices-cannot/docs/dev-reports/JOOWP-304.md). The Dev VM Lighthouse run and its evidence were not produced, as directed by the owner amendment.

Refs: JOOWP-304
AI-Run: bf1cfec5-671f-4494-b60a-a27da49b5f34 (codex-01, codex/gpt-6-luna)
@jooservices-aiflow-bot

Copy link
Copy Markdown
Contributor Author

AI Flow verify: FAIL (verify failed).

Findings:

  • docker/scripts/perf-vm.sh: The SSH tunnel listens on host loopback, while the Node container connects through host.docker.internal. Make the tunnel reachable from the container or add a reachable relay, then verify that connection from the runtime.

Checks: composer install --no-interaction --prefer-dist PASS; npm ci --no-audit --no-fund PASS; make lint PASS; make analyse PASS; make test-unit PASS (288 PHPUnit tests, 3,266 assertions; 48 Vitest files, 373 tests); JOOS_TICKET= make test-tooling PASS; make perf not run per owner amendment.

…ium for Lighthouse (G7)

Updated [perf-vm.sh](/srv/aiflow/work/JOOWP/JOOWP-304-core-make-perf-theme-jooservices-cannot/docker/scripts/perf-vm.sh) to expose the SSH forward and verify `/json/version` from the Node runtime before Lighthouse starts; OpenSSH documents `-g` for remote clients of local forwards ([ssh(1)](https://man.openbsd.org/OpenBSD-7.7/ssh.1)). The report records that the Lighthouse run and AC1/AC2 evidence were not produced, per the owner amendment.

Refs: JOOWP-304
AI-Run: ce5cf1af-de7d-4c48-9a31-a8b11b571f6c (codex-01, codex/gpt-6-luna)
@jooservices-aiflow-bot

Copy link
Copy Markdown
Contributor Author

AI Flow verify: FAIL (verify failed).

Findings:

  • docker/scripts/perf-vm.sh (local_bind="0.0.0.0", ssh -M -g, the -O forward -L "$local_bind:..." line): the unauthenticated Chromium DevTools tunnel is exposed on every host interface. Bind it only to the Docker bridge gateway address that the Node runtime reaches, or keep it on loopback and use a relay on that address, and drop -g. Keep the verification from the Node runtime.
  • tests/tooling/ticket-prefix.sh: the grep assertions require local_bind="0.0.0.0" and ssh -M -g, which would lock in the insecure bind. Update them to check the restricted bind.

Checks: composer install, npm ci, make lint, make analyse and make test-unit all passed (exit 0). tests/tooling/ticket-prefix.sh passed. make perf was not run (out of scope under the owner amendment, and the Dev VM is unavailable here).

…ium for Lighthouse (G7)

The DevTools tunnel in `perf-vm.sh` binds only to the Docker bridge gateway address (`PERF_CDP_BIND` overrides it) and `ssh -g` is removed. The Node runtime still verifies the endpoint before Lighthouse starts, and the grep assertions in `tests/tooling/ticket-prefix.sh` now enforce the restricted bind. The Dev VM Lighthouse run and its AC1/AC2 evidence were not produced, per the owner amendment.

Refs: JOOWP-304
AI-Run: e722534a-8337-42d7-915d-3f82007f8271 (claude-02, claude/sonnet)
@jooservices-aiflow-bot

Copy link
Copy Markdown
Contributor Author

AI Flow verify: FAIL (verify failed).

Findings:

  • artifacts/package/jooservices-resume-0.1.0.zip: Unrelated archive diff with unchanged uncompressed contents; restore it from origin/develop.
  • docs/dev-reports/JOOWP-304.md:24: Vitest totals are stale; update them to 49 files / 377 tests.

Checks: composer install --no-interaction --prefer-dist PASS; npm ci --no-audit --no-fund PASS; make lint PASS; make analyse PASS; make test-unit PASS (PHPUnit 288 tests / 3,266 assertions; Vitest 49 files / 377 tests); bash tests/tooling/ticket-prefix.sh PASS; make perf not run per owner amendment.

…ium for Lighthouse (G7)

Restored the package archive to match `origin/develop` and corrected the Vitest totals in [JOOWP-304.md](/srv/aiflow/work/JOOWP/JOOWP-304-core-make-perf-theme-jooservices-cannot/docs/dev-reports/JOOWP-304.md). The report records that Lighthouse evidence was not produced, as directed by the owner amendment.

Refs: JOOWP-304
AI-Run: f2d195da-5a05-4029-b174-2e13d220a8e1 (codex-02, codex/gpt-6-luna)
@jooservices-aiflow-bot
jooservices-aiflow-bot Bot marked this pull request as ready for review October 23, 2026 14:46
@jooservices-aiflow-bot
jooservices-aiflow-bot Bot merged commit 2584b91 into develop Oct 23, 2026
6 checks passed
@jooservices-aiflow-bot
jooservices-aiflow-bot Bot deleted the JOOWP-304-core-make-perf-theme-jooservices-cannot branch October 23, 2026 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants