Skip to content

feat: JOOWP-204: [THEME] T11.3 Cross-engine runs (WebKit and Firefox) and fixes - #56

Draft
jooservices-aiflow-bot[bot] wants to merge 1 commit into
developfrom
JOOWP-204-theme-t11-3-cross-engine-runs-webkit-and
Draft

jooservices-aiflow-bot[bot] wants to merge 1 commit into
developfrom
JOOWP-204-theme-t11-3-cross-engine-runs-webkit-and

Conversation

@jooservices-aiflow-bot

Copy link
Copy Markdown
Contributor

Jira: JOOWP-204

Summary

Added cross-engine Playwright projects for WebKit and Firefox at 390×844, 820×1180 and 1440×900. Added an engine-feature spec with clipboard-fallback tests, guarded the unguarded :has() rules with @supports, documented every fallback, and added a manual CI job that installs both browsers. The WebKit and Firefox runs themselves (AC2, AC6) were not executed here; only Chromium is installed and there is no WordPress test site, and the evidence file says so.

Tests

composer install and npm ci ran. make lint, make analyse and make test-unit pass (Vitest 50 files, 376 tests, including the new static guards). The e2e specs and the WebKit/Firefox projects were not run.

Run

  • account: claude-02 (claude/sonnet)
  • run: 28c20a2f-beb3-47c3-8e7b-cce6415b7954, fence 3
  • files changed: 13

Opened as a draft by AI Flow v4; verification runs next (In Verify).

… and fixes

Added cross-engine Playwright projects for WebKit and Firefox at 390×844, 820×1180 and 1440×900. Added an engine-feature spec with clipboard-fallback tests, guarded the unguarded `:has()` rules with `@supports`, documented every fallback, and added a manual CI job that installs both browsers. The WebKit and Firefox runs themselves (AC2, AC6) were not executed here; only Chromium is installed and there is no WordPress test site, and the evidence file says so.

Refs: JOOWP-204
AI-Run: 28c20a2f-beb3-47c3-8e7b-cce6415b7954 (claude-02, claude/sonnet)
@coderabbitai

coderabbitai Bot commented Oct 23, 2026

Copy link
Copy Markdown

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: d031974c-21d0-4e40-b3e9-7cca37db4d6d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jooservices-aiflow-bot

Copy link
Copy Markdown
Contributor Author

AI Flow verify: FAIL (verify failed).

Findings:

  • .github/workflows/nightly.yml: The job uses a GitHub-hosted runner, but make demo and make test-e2e require the shared Workspaces Docker and Dev VM browser. The job will fail before the browser tests run. Use a runner with those services or provision an equivalent environment.
  • tests/e2e/playwright.config.ts: The responsive specs use desktop device contexts and are excluded from the engine phone projects, so setting the viewport to 390×844 does not provide mobile emulation for the responsive subset. The Firefox phone project also sets isMobile: false. Configure the responsive run for mobile emulation on each engine, or resolve the Firefox limitation against AC1.
  • artifacts/evidence/JOOWP-204/results.md: The new WebKit and Firefox runs are recorded as “not run.” The JOOWT-246 reports cover only the shared suite, not these theme-specific tests. Run the subsets and record their results and any Jira Bug fixes or owner-approved deferrals to satisfy AC2 and AC6.
  • themes/jooservices/tests/e2e/cross-engine.spec.ts: The dvh check measures a newly created generic element against window.innerHeight; it does not exercise the terminal’s dvh styling or Safari’s changing URL bar. Test the actual component under URL-bar viewport changes and record evidence for that behavior.
  • themes/jooservices/docs/browser-fallbacks.md: The documented fallback tests do not exercise several unsupported paths. The dialog unit test always stubs showModal, and the :has() E2E test checks support is present; it never verifies the fallback behavior. Add tests that exercise those unsupported paths, or correct the documentation where a fallback is not tested.

Checks: composer install --no-interaction --prefer-dist PASS; npm ci --no-audit --no-fund PASS; make lint PASS; make analyse PASS; make test-unit PASS (288 PHPUnit, 380 Vitest). Cross-engine E2E could not run: missing Workspaces shared Docker configuration. No AGENTS.md or docs/SPEC.md was found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants