Repository navigation
fix: skip already-elapsed periods when catching up - #10
Merged
Merged
Conversation
After downtime the scheduler generated a poll for every missed period, including ones whose raids had all started, then closed them on the same tick. PublishNext now advances past such periods without inserting a poll, so catching up publishes only the period members can still answer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PublishNextnow advances past a period whose last occurrence has already started, without inserting a poll. Catching up only publishes periods members can still vote on.skipped elapsed periodfor these steps instead of a misleadingpoll cycle advancedwith poll ID 0.v0.0.10.Verification
TestCatchUpSkipsElapsedPeriods: three weeks offline, then catching up creates only the current period's poll (2026-09-28), and the schedule advances to2026-10-05. Before the fix it created four polls (09-07,09-14,09-21,09-28).go test ./...withTEST_DATABASE_URLrun three times, plusgo vet ./....