Repository navigation
test: cover the remaining regressions from earlier bugs - #12
Merged
Merged
Conversation
Every bug found so far now has a test that fails if it returns: - Discord's global_name is decoded at sign-in, and only guilds the bot is in are kept. - The Schedule tab renders from the saved schedule without requesting Discord channels until the leader clicks Change. - The saved server and channel names are shown, not generic labels. - Raid times use a 24-hour clock. Each test was checked by reintroducing its bug and watching it fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds regression tests for the four earlier bugs that were fixed without one. Every bug found so far now has a test that fails if it comes back.
global_name)TestDiscordIdentityReadsGlobalNameAndBotGuilds: decodesglobal_nameagainst a stub Discord API and keeps only guilds the bot is in/channelsrequest; clicking Change fetches them#raid-schedule21:00with no AM/PMTests only, so there's no version bump.
Verification
hourCycle: "h12"go test ./...,go vet ./...,npm run checkandnpm run format:checkalso pass.