Repository navigation
feat(web): show raid times in each viewer's timezone - #15
Merged
Merged
Conversation
The availability grid showed every date in the team's timezone, so a
member abroad had to convert times themselves. Dates and times now use
the viewer's timezone, with the team's time beneath when it reads
differently ("Wed 7 21:00 Tokyo" when the day differs too). The "next
timetable posts" line follows the viewer as well; the schedule editor
stays in team time because that is what it configures.
Release v0.0.14.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The availability grid showed every date in the team's timezone, so a member abroad had to convert the times themselves.
21:00 Tokyo, orWed 7 21:00 Tokyowhen the day differs too. It is hidden when the viewer is in the team's timezone.Asia/Tokyo, the fixtures' team timezone, so existing assertions are deterministic. Individual tests override it.Release v0.0.14.
Tests
Wed 7 · 05:00 · 21:00 TokyoThu 8 · 01:00 · Wed 7 21:00 Tokyonpm run check,format:check,build, and Playwright (23 passed, 1 desktop-skipped phone test) all pass locally.