Drop the emulator console auth token workaround - #32
Merged
Merged
Conversation
The preview emulator used to read ~/.emulator_console_auth_token without ever creating it, so the console stayed unauthenticated and 'adb emu kill' answered "KO: unknown command". CI and the replay script created the file themselves to unlock the full console command set. The emulator has created its own token for a while now, so the workaround is dead code: the step is removed from the composite action, the replay script no longer writes the file, and the comments and README that pointed at it are updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The "Ensure emulator console auth token" step dates from a preview-emulator bug: the emulator read
~/.emulator_console_auth_tokenbut never created it, leaving the console unauthenticated soadb emu killfailed withKO: unknown command. That bug has been fixed for a while, so the workaround is dead code.What changed
.github/actions/preview-emulator/action.ymland updated its description.scripts/replay-preview-multirun.shand the README paragraph describing it.No behaviour change is expected: the emulator creates the token itself, so graceful shutdown through
adb emu killkeeps working. Same cleanup as jpcottin/ShakeDetectorLight#7.