Repository navigation
Small performance improvement of flags (RI) - #304
Conversation
Merging this PR will improve performance by ×5.61 warning
Performance Changes
Tip Curious why performance improved? Comment Comparing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #304 +/- ##
==========================================
+ Coverage 88.09% 88.12% +0.02%
==========================================
Files 41 41
Lines 5654 5632 -22
Branches 1520 1508 -12
==========================================
- Hits 4981 4963 -18
+ Misses 319 318 -1
+ Partials 354 351 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
https://github.com/jquast/wcwidth/security/code-scanning/110 I'm not 100% sure what the problem is, but I think this will fix it.
Use the same UB stance that is used for ZWJ: RI's are placed in pairs so we can more simply track ri_unpaired, and ri_unpaired_before to more rapidly determine RI pairs. This means it might get it "wrong" for invalid unicode sequences, like combining characters with RI's, but we don't care to try measure about that correctly.