Repository navigation
Preserve cell styles when clipping overtyped text - #305
Open
civilwarinfrance wants to merge 1 commit into
Open
civilwarinfrance wants to merge 1 commit into
civilwarinfrance wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clipping a colored line after a backspace or carriage return can apply the wrong style to both overwritten and untouched characters. For example,
clip('\x1b[31mabc\x1b[0m\bX', 0, 3)currently renders all ofabXin red, althoughXwas written after the reset and should use the default color.Record the immutable SGR state alongside painted cells and restore it when reconstructing them in column order. Track the reconstructed output's final style for the trailing reset. This also preserves the style of untouched text when an overwrite introduces a new color. The C extension already delegates cursor movement to this Python painter, so it uses the same fix.
Validation:
wcwidth/__init__.py, also present on the original revision.AI assistance was used to investigate, implement and test this change.