Skip to content

External Headers - #1049

Closed
zweizeichen wants to merge 4 commits into
jrobichaud:mainfrom
helmholtzcloud:external-headers
Closed

zweizeichen wants to merge 4 commits into
jrobichaud:mainfrom
helmholtzcloud:external-headers

Conversation

@zweizeichen

Copy link
Copy Markdown

#1048

@jrobichaud Okay, I took a stab at this. Feel free to cherry-pick and edit directly if that works better for you. I tried to address introducing the new config flags, updating the docs and covering the change with tests.

What's missing: contribution notes, test run

Cheers!

@codecov

codecov Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (d82f525) to head (eb142e5).
⚠️ Report is 31 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##              main     #1049     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files           51        34     -17     
  Lines         2272       532   -1740     
  Branches        36         5     -31     
===========================================
- Hits          2272       532   -1740     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jrobichaud

Copy link
Copy Markdown
Owner

There is an unrelated failure, it has been a while since i upgraded packages.

However there is a problem with one of the test regarding your change.

@zweizeichen

Copy link
Copy Markdown
Author

Should be fixed (I did this a bit on short notice), if there's additional defects, I can look into them tomorrow.

@zweizeichen

Copy link
Copy Markdown
Author

Tests are passing now on my fork (apart from the unrelated failure). I also opened #1050 which might be useful for bumping the project's dependencies (getting working pipelines apart from linting over there, but that should be easy to fix).

@jrobichaud

Copy link
Copy Markdown
Owner

i took over your branch, ill make the fixes. see #1054

@jrobichaud jrobichaud closed this Oct 24, 2026
@jrobichaud

Copy link
Copy Markdown
Owner

(and thanks!)

@jrobichaud jrobichaud mentioned this pull request Oct 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants