Repository navigation
Conversation
AppSettings.CELERY_TASK_NOTICE_LOG_LEVEL read DJANGO_STRUCTLOG_CELERY_TASK_RETRY_LOG_LEVEL, so setting the documented DJANGO_STRUCTLOG_CELERY_TASK_NOTICE_LOG_LEVEL had no effect on task_retrying and task_revoked. Read the documented name first and keep the previous one as a fallback. Also fix two configuration.rst rows that named DEFAULT_LOG_LEVEL and START_LOG_LEVEL without the STATUS_ prefix the code reads.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/configuration.rstdocumentsDJANGO_STRUCTLOG_CELERY_TASK_NOTICE_LOG_LEVELfortask_retryingandtask_revoked, butAppSettings.CELERY_TASK_NOTICE_LOG_LEVELreadsDJANGO_STRUCTLOG_CELERY_TASK_RETRY_LOG_LEVEL, so the documented setting has no effect:This reads the documented name and falls back to the
RETRYname, so anyone who already set that one keeps their level. Two rows in the same table nameDJANGO_STRUCTLOG_DEFAULT_LOG_LEVELandDJANGO_STRUCTLOG_START_LOG_LEVEL, while the code readsSTATUS_DEFAULT_LOG_LEVELandSTATUS_START_LOG_LEVEL(as listed in #1024); those rows are corrected.Tests added in
test_app_settings.py(documented name, previous name, documented name winning) andtest_receivers.py(the retry event at the configured level); they fail on main. Thetest_appsuite passes apart fromtest_defer_task, which needs a Redis server I didn't run; ruff, black and isort pass.Written with AI assistance (Claude); I have reviewed the change.