Repository navigation
fix: treat Dropbear kexguess2 as negotiation marker, not PQ-unsafe KEX - #377
Closed
ranas-mukminov wants to merge 1 commit into
Closed
ranas-mukminov wants to merge 1 commit into
ranas-mukminov wants to merge 1 commit into
Conversation
kexguess2@matt.ucc.asn.au is a Dropbear KEX guessing marker (data field NULL), not an actual key-exchange algorithm. Flagging it with WARN_NOT_PQ_SAFE is misleading (jtesta#375). Classify it like ext-info / kex-strict pseudo-algorithms with an INFO note instead.
Owner
|
Fixed in 68953dd. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #375:
kexguess2@matt.ucc.asn.auwas listed withWARN_NOT_PQ_SAFE, but it is not a real key-exchange algorithm.Dropbear defines it as a negotiation / guessing accelerator (
dataisNULLincommon-algo.c); it does not perform a KEX. Marking it post-quantum-unsafe therefore produces a false warning on Dropbear peers.Changes
INFO_KEXGUESS2describing it as a pseudo-algorithm / marker (same pattern asext-info-*andkex-strict-*).WARN_NOT_PQ_SAFEentry with an INFO classification.test_kex_pq_unsafealongside the other markers.References
Test plan
pytest test/test_ssh2_kexdb.py(2 passed)kexguess2@matt.ucc.asn.au— no PQ-unsafe warning for that name; INFO note present instead.