Repository navigation
chore(no-release): clarify GitOps ownership and validation - #28
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #27
Related audit: justgithubaccount/app-poly-gitops-infra#27
Related application workstream: justgithubaccount/app-poly-gitops-infra#30
Desired-state safety
No rendered Kubernetes object changes. Exact baseline/head hashes:
e97f127ba4893e3f1e3650f9990621394179cceb59934b28dc059221e03f6b2c(18 resources)479edc2b4fc4e90477ac0001a6ced7045c4b268824686c9a6ca66f520f410312(5 resources)cmpis byte-identical for both roots. No chart, image, target revision, destination, Secret, Namespace, release, deployment, Argo sync, cloud workflow, or live Kubernetes operation was changed or invoked.Offline verification
npm audit --audit-level=criticalPASSSecurity and unresolved decisions
Current audit still reports one moderate
ip-addressadvisory (GHSA-rxp7-6hxx-x8q5) and one highundicipackage affected byGHSA-4qv8-2p9j-2685,GHSA-xjj6-f33q-929c,GHSA-2m5v-pch6-74hx,GHSA-qrxm-fqhp-jwvm, andGHSA-9fm3-97px-rjf6. Both are bundled inside the npm executable reached throughsemantic-release@25.0.9 -> @semantic-release/npm@13.2.0 -> npm@11.21.1; the direct release packages are current.npm audit fix --dry-runchanges nothing, and the fixed npm major is outside the plugin declared compatibility range. This PR does not force an unsupported override and instead fails CI on critical findings.Operator/runtime evidence is still required before removing the recursive
root-app.yaml, dormant ApplicationSets/AppProjects, the devopen-webuiNamespace, alternate database resources, or incomplete tst/stg/prd scaffolds. The ownership document gives the exact evidence and migration constraints.Rollback
Revert this single no-release commit. Because dev/smoke renders are unchanged, rollback has no Kubernetes prune or workload consequence.
Status: NO_MERGE / NO_DEPLOY.