Repository navigation
refactor: split the command parser by command family - #418
Merged
Merged
Conversation
command/parse.rs held every command parser in 3,800 lines. The parsers now live in one file per family under command/parse/, and parse/mod.rs keeps from_frame and the shared argument helpers. No code changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ember-protocol/src/command/parse.rsheld every command's parser in about 3,800 lines. It is now a directory:parse/mod.rshasCommand::from_frame, which picks a parser by command name, plus the shared helpers for pulling strings and numbers out of frames, and the SCAN and score-bound parsers several families use.strings,keys,lists,sorted_sets,hashes,sets,server,cluster,pubsub,vectorandproto. The largest is about 500 lines.The functions moved unchanged. The family parsers became
pub(super)sofrom_framecan call them, and the// --- x commands ---section comments were dropped because the file names now do that job. The protocol tests pass unchanged.