Repository navigation
refactor: split the shard module - #419
Merged
Merged
Conversation
shard/mod.rs was about 3,000 lines. The request and response types move to shard/request.rs and dispatch, which maps each request to a keyspace operation, moves to shard/dispatch.rs. mod.rs keeps the shard handle, startup and the message loop. No code changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ember-core/src/shard/mod.rswas about 3,000 lines and mixed three concerns. It now has three files:shard/request.rs: theshard_request!macro,ShardRequest,ShardResponseandShardMessage, about 500 lines. They are re-exported fromshardas before, so no paths outside the module change.shard/dispatch.rs:dispatch, which maps each request to a keyspace operation, and its small helpers, about 980 lines.shard/mod.rs: the shard handle, startup and recovery wiring, the message loop and the tests, about 1,500 lines.The code moved unchanged.
dispatchandis_writebecamepub(super)so the rest of the shard can call them. Core tests pass with and without the optional features, and the server builds unchanged.