Repository navigation
Add pipeline job cancel endpoints - #770
Merged
Merged
Conversation
Add PUT /pipelines/jobs/{job_id}/cancel and PUT
/admin/pipelines/jobs/{job_id}/cancel, mirroring the existing standard
job cancel routes and reusing the shared job+flow fetch helpers.
Regular cancel is listed before runner_status; admin cancel is listed
after runner_status, matching the existing route ordering conventions
for standard jobs.
Update NERSCJAWSRunner.cancel_job/_cancel_job to accept pipeline jobs,
since all pipeline jobs run exclusively through this flow: refresh
from the correct collection and thread the pipeline flag through to
job state updates.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #770 +/- ##
==========================================
- Coverage 65.34% 65.32% -0.02%
==========================================
Files 76 76
Lines 7739 7747 +8
==========================================
+ Hits 5057 5061 +4
- Misses 2682 2686 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add PUT /pipelines/jobs/{job_id}/cancel and PUT
/admin/pipelines/jobs/{job_id}/cancel, mirroring the existing standard job cancel routes and reusing the shared job+flow fetch helpers. Regular cancel is listed before runner_status; admin cancel is listed after runner_status, matching the existing route ordering conventions for standard jobs.
Update NERSCJAWSRunner.cancel_job/_cancel_job to accept pipeline jobs, since all pipeline jobs run exclusively through this flow: refresh from the correct collection and thread the pipeline flag through to job state updates.