Repository navigation
Make not_falsy generic to preserve argument types for static analysis - #779
Merged
Merged
Conversation
Typing obj as Any erased the caller's type on return, so attributes assigned via not_falsy (e.g. self._s3cli = not_falsy(s3cli, ...)) were inferred as Any, breaking IDE go-to-definition/references on their methods.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #779 +/- ##
=======================================
Coverage 64.73% 64.73%
=======================================
Files 77 77
Lines 7613 7614 +1
=======================================
+ Hits 4928 4929 +1
Misses 2685 2685 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Typing obj as Any erased the caller's type on return, so attributes assigned via not_falsy (e.g. self._s3cli = not_falsy(s3cli, ...)) were inferred as Any, breaking IDE go-to-definition/references on their methods.