Repository navigation
Chainweb Revolution - #49
Open
edmundnoble wants to merge 453 commits into
Open
edmundnoble wants to merge 453 commits into
edmundnoble wants to merge 453 commits into
Conversation
Change-Id: Id0000000c710b3254c28490df4102788ad05b899
Change-Id: Id0000000e62e4d92520fbb52730df5ff49dbace1
Change-Id: Id0000000253662d2498dc6582f9a1782d2f2fb79
Change-Id: Id000000030b06b731faa8c6e47ff1b891945b720
Change-Id: Id0000000c7ecef14f070061716476b1aff90d751
Change-Id: Id000000003df0e6228643907b06fda6e13d2dea2
Change-Id: Id00000001b24cc3d269cffcf1b3a67d230747c18
Change-Id: Id000000056296ea25046e7a8b9b001e84c259047
As large as traces can be sometimes, ForkInfoSyncFailure is a very serious error and one failure case is that the trace is insufficient for the payload provider to resolve the fork. Change-Id: Id00000002dbaa0d9222fabfe4308ebca179301d0
1. `false` is no longer allowed, booleans are case-sensitive. 2. `debug-info` is an integer, not a bool. Change-Id: Id0000000920444ab87872458636e74d196058c2c
1. Many utilities moved from ChainwebPactDb to Backend.Utils. (these are not specific to PactDb though they are related to storage) 2. Stop maintaining a "latest" in ConsensusState table. The latest row in the BlockHistory table reflects the true "latest" block, and duplication between the two may cause bugs. Test Plan: Run Pact tests as normal. Ran on mainnet database locally. Reviewers: rsoeldner, jmcardon, larskuhtz Reviewed By: larskuhtz, rsoeldner Pull Request: kadena-io#2260
Sometimes consensus and Pact are out of sync; this is normal and expected because catchup is not atomic w.r.t. payload providers. In particular Pact can be ahead of consensus. However, consensus' store of validated block headers is used to migrate the BlockHistory table. If the corresponding headers are missing from consensus, we can't migrate those rows of the BlockHistory table. Thus *we need to avoid erroring out in that case*. Additionally, the rows of all other Pact tables should agree with the highest BlockHistory row. Thus *we need to execute a rewind to that block at the end of the migration*. Test Plan: replay on mainnet database. Change-Id: Id000000074e2d41ff0d0254f3d31e9c712adc6e5 Reviewers: jmcardon, larskuhtz, rsoeldner Reviewed By: rsoeldner, larskuhtz Pull Request: kadena-io#2261
Test Plan: none required. Change-Id: Id000000068eb15bd1ff51bc3590ac087c73da495 Reviewers: chessai, larskuhtz Reviewed By: chessai, larskuhtz Pull Request: kadena-io#2262
This reverts commit 2d3c08e.
Created using jj-spr 1.3.6-beta.1
Still has a TODO for supporting minimumBlockHeaderHistory in the new Pact header oracle.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…ntain permissions' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
The cabal-cache sync step fails intermittently (e.g. S3 access issues), aborting otherwise healthy builds. Mark it continue-on-error so builds proceed from source when the remote cache is unavailable.
The macos-latest runners fail to link with: ld: tapi error: malformed file ... MacOSX27.0.sdk ... unknown architecture arm64e.x1-macos because clang and ld are picked from mismatched toolchains. Probe both xcode-select locations and keep the one that can actually link.
The macOS workflow still pointed at the upstream kadena-cabal-cache bucket with the upstream secret names, so the cache sync failed with exit code 1 on this fork. Point it at community-kda-cabal-cache with the kda_community_* secrets, matching applications.yml.
CryptoPascal31
added this pull request to stack #51
October 23, 2026 09:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes:
PactService, with automatic migration from the previous version. This comes with a drastic simplification of the data flow between consensus and Pact, which should make future Pact development easier.There's much more to say about the EVM payload provider, but it will require more testing and updating to bring to mainnet, not to mention operational challenges that come with multi-process coordination and changes to the build.