Repository navigation
docs(readme): record that rowspec now calls the reusable workflow - #25
Merged
Merged
Conversation
The status line said rowspec's CI was still its own and the kit untagged. rowspec#78 moved its suite and gate onto kind.yml, reporting as `kind / conformance`, after rowspec#77 moved its pin; kindkit is tagged v0.1.0. The adoption section now says what rowspec did rather than what it would have to do.
CameronBrooks11
added a commit
that referenced
this pull request
Oct 8, 2026
…#26) ## What `check.yml` now triggers on ```yaml on: push: branches: [main] pull_request: ``` instead of `on: [push, pull_request]`. This is the change kindspec/rowspec#67 made to rowspec's `check.yml`. No job is renamed and no path filter is added, so the ruleset (`check`, `kind / conformance`) needs no change. `kind.yml` is not changed: it runs only through `workflow_call`, so its caller's triggers are its triggers, and the `kind` caller job lives in `check.yml`. ## Why With a bare `push`, every push to a PR branch starts two `check` suites. Each required context then has two producers on the PR head. On #25's head (`79d194a`), from `gh api repos/kindspec/kindkit/commits/<sha>/check-runs --jq '.check_runs[] | "\(.name)\t\(.check_suite.id)"'`: ``` check 102179455195 (push) check 102179470311 (pull_request) kind / conformance 102179455195 (push) kind / conformance 102179470311 (pull_request) ``` The caller job has the same defect as `check`, because both are jobs of the same workflow; fixing the trigger fixes both. ## Testing - The new trigger parses as `{'push': {'branches': ['main']}, 'pull_request': None}` under the required-checks audit's YAML reader, and its `pr_trigger` gives a pull_request producer into `main`. - `just check && just test`: `All checks passed!`, `220 passed`. - **On this PR's head** (`c3e3c7f`), same command: each required context once, from the `pull_request` suite. The branch was pushed before the PR was opened, and that push started no run. ``` check 102183598609 (pull_request) kind / conformance 102183598609 (pull_request) ``` - **Still open after merge**: `main` should get a `push` run on the merge commit. Refs kindspec/rowspec#43 Signed-off-by: Cameron Brooks <cambrooks3393@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README's status line still said rowspec's CI was its own and that the kit was untagged. Both are out of date:
kind.yml, called at the commit itspyproject.tomlpins (8e21b55, moved there by rowspec#77). It reports askind / conformance.v0.1.0(git ls-remote --tags https://github.com/kindspec/kindkitpeels it tobf716e3);mainis ahead of it (gh api repos/kindspec/kindkit/compare/v0.1.0...main --jq .ahead_by). It is not on PyPI (curl -s -o /dev/null -w '%{http_code}' https://pypi.org/pypi/kindkit/jsonprints 404).Also corrected, in the workflow section:
v0.1.0lacks all three ofroot,KINDKIT_REPORT_JSONandKINDKIT_GATE_REPORT(git grepatv0.1.0finds neither variable underkindkit/, andReport.to_jsonthere writes onlykindkit_report,casesandfailures).conformanceis already a required check" described rowspec's job as running "corpus checks", which rowspec#68 removed, and spoke of the adoption as future. It now records what rowspec did: it keptconformanceand requires both it andkind / conformance(gh api repos/kindspec/rowspec/rules/branches/mainlistsconformance, xlsx-extra, passes-on-a-good-tree, fails-on-a-broken-total, kind / conformance).Docs only.
just check(28 files formatted, ruff clean) andjust test(220 passed) in this branch.