Repository navigation
Isolate test landing locks per workspace (knit) - #258
Merged
Merged
Conversation
… paths Windows CI failed in three ways: parallel tests that share project `demo` grabbed the same landing ownership lock in the shared temp directory (`os error 80` while another test held it); the run checkout directory under `<run>.run.checkouts/<64-character hash>` grew past Windows' path limit (`fatal: '$GIT_DIR' too big'`); and the live-output streaming test gave `sh` five seconds to start, which Windows runners regularly miss. The test harness now gives every spawned knit process a temp directory private to its workspace (TMP/TEMP/TMPDIR keyed by cwd), so landing locks are shared only inside a single test; revert_landed's local wrappers for the same problem fold back into the harness. Run checkout directories use a twelve-character hash prefix, like plan fingerprints already do. The streaming test's deadline rises to thirty seconds; the step's own timeout still bounds the command. Knit-Group: kg_20261012_bbe991 Knit-Bundle: isolate-test-landing-locks-per-workspace
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Knit Bundle
View bundle
This PR is part of Knit bundle
isolate-test-landing-locks-per-workspace.See the other review objects in this bundle:
knit: Isolate test landing locks per workspace (knit) #258 (this PR)Bundle id:
isolate-test-landing-locks-per-workspaceBundle title: Isolate test landing locks per workspace