Repository navigation
Keep landing ownership records in the knit home (knit) - #260
Merged
marc-merino merged 1 commit intoOct 12, 2026
Merged
Conversation
Local landing locks and each project's latest-run generation lived in the OS temp directory. Temp cleanup could silently drop a lock meant to survive a crash, or the record that a previous landing left unresolved effects, and on Linux the first user to land owned /tmp/knit-landing-ownership, so every other user on the machine failed with a misleading "landing resource is owned". They now live in landing-ownership/ next to the user-level config (KNIT_HOME, XDG_CONFIG_HOME/knit or ~/.config/knit). Records an earlier release left in the temp directory still block, so an upgrade never skips an in-flight landing or an unresolved generation. Unit tests keep a temp directory so they never write into a developer's real config. The test harness now gives every test its own knit home, which isolates the locks per test; the per-workspace temp directories added for the same purpose are removed. Knit-Group: kg_20261012_e3ecdd Knit-Bundle: keep-landing-ownership-records-in-the-knit-home
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Knit Bundle
View bundle
This PR is part of Knit bundle
keep-landing-ownership-records-in-the-knit-home.See the other review objects in this bundle:
knit: Keep landing ownership records in the knit home (knit) #260 (this PR)Bundle id:
keep-landing-ownership-records-in-the-knit-homeBundle title: Keep landing ownership records in the knit home