Repository navigation
Give every revert clone a unique directory (knit) - #262
Merged
marc-merino merged 1 commit intoOct 12, 2026
Merged
Conversation
Commit group, revert group, revert plan and ledger node ids took their six hex characters from the low bits of the clock. macOS clocks tick in microseconds, so ids requested in the same tick came out equal: parallel PR reverts then cloned into the same .knit/revert-clones directory and all but one failed with "destination path already exists". Each process now starts from a random suffix and counts up, so its ids never repeat while keeping the same <prefix>_<date>_<6 hex> shape. Knit-Group: kg_20261012_59fdd7 Knit-Bundle: give-every-revert-clone-a-unique-directory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Knit Bundle
View bundle
This PR is part of Knit bundle
give-every-revert-clone-a-unique-directory.See the other review objects in this bundle:
knit: Give every revert clone a unique directory (knit) #262 (this PR)Bundle id:
give-every-revert-clone-a-unique-directoryBundle title: Give every revert clone a unique directory