Resolve contact names by MID, including non-friends - #9
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. 鈿欙笍 Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a group member is not in the friend list, applications only have the sender MID and cannot show the person's name.
line contacts --mid MIDnow looks up supplied user IDs directly throughGetContactsV2, including multiple IDs in one command. It preserves input order, reports omitted profiles explicitly, and leaves the existing friend-list output unchanged.The change also rejects malformed contact responses, documents lookup and partial-result behavior, and updates the CLI guide and translated READMEs.
Validation:
go test -race ./internal/... ./cmd/line ./pkg/line/... ./pkg/e2ee,go vet ./internal/... ./cmd/line ./pkg/line ./pkg/e2ee ./pkg,staticcheck ./internal/... ./cmd/line ./pkg/line ./pkg/e2ee ./pkg,./build.sh, and command help checks passed. Tests use fake APIs; no live LINE request was made.Closes #8